feat: добавлены тесты для достижения 30% покрытия

- AuthHandler: 5 тестов (5.3% покрытия)
- AuthMiddleware: 6 тестов (88.9% покрытия)
- Repository: дополнительные тесты (34.2% покрытия)

Общее покрытие: 17.6% (было 9.6%)

Все тесты проходят успешно!
Следующий этап: добавление тестов для остальных handlers и service layer
This commit is contained in:
2025-08-27 19:34:25 +04:00
parent c8224f072a
commit 76df5d6abe
3 changed files with 482 additions and 0 deletions

View File

@@ -0,0 +1,216 @@
package handlers_test
import (
"bytes"
"context"
"encoding/json"
"net/http"
"net/http/httptest"
"testing"
"github.com/gin-gonic/gin"
"github.com/google/uuid"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
"erp-mvp/core-service/internal/api/handlers"
"erp-mvp/core-service/internal/models"
)
// MockAuthService мок для AuthService
type MockAuthService struct {
mock.Mock
}
func (m *MockAuthService) Register(ctx context.Context, req *models.RegisterRequest) (*models.LoginResponse, error) {
args := m.Called(ctx, req)
return args.Get(0).(*models.LoginResponse), args.Error(1)
}
func (m *MockAuthService) Login(ctx context.Context, req *models.LoginRequest) (*models.LoginResponse, error) {
args := m.Called(ctx, req)
return args.Get(0).(*models.LoginResponse), args.Error(1)
}
// TestNewAuthHandler тестирует создание AuthHandler
func TestNewAuthHandler(t *testing.T) {
// Arrange
mockService := &MockAuthService{}
// Act
handler := handlers.NewAuthHandler(mockService)
// Assert
assert.NotNil(t, handler)
}
// TestAuthHandler_Register_Success тестирует успешную регистрацию
func TestAuthHandler_Register_Success(t *testing.T) {
// Arrange
gin.SetMode(gin.TestMode)
mockAuthService := &MockAuthService{}
handler := handlers.NewAuthHandler(mockAuthService)
router := gin.New()
router.POST("/register", handler.Register)
registerReq := &models.RegisterRequest{
OrganizationName: "Test Workshop",
UserEmail: "admin@test.com",
UserPassword: "password123",
OrganizationType: "workshop",
}
expectedResponse := &models.LoginResponse{
Token: "test_token",
User: models.UserResponse{
ID: uuid.New(),
Email: "admin@test.com",
Role: "admin",
},
Organization: models.OrganizationResponse{
ID: uuid.New(),
Name: "Test Workshop",
Type: "workshop",
},
}
mockAuthService.On("Register", mock.Anything, registerReq).Return(expectedResponse, nil)
reqBody, _ := json.Marshal(registerReq)
// Act
w := httptest.NewRecorder()
req, _ := http.NewRequest("POST", "/register", bytes.NewBuffer(reqBody))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
// Assert
assert.Equal(t, http.StatusCreated, w.Code)
var response models.LoginResponse
err := json.Unmarshal(w.Body.Bytes(), &response)
assert.NoError(t, err)
assert.Equal(t, expectedResponse.Token, response.Token)
assert.Equal(t, expectedResponse.User.Email, response.User.Email)
assert.Equal(t, expectedResponse.Organization.Name, response.Organization.Name)
mockAuthService.AssertExpectations(t)
}
// TestAuthHandler_Register_ValidationError тестирует ошибку валидации при регистрации
func TestAuthHandler_Register_ValidationError(t *testing.T) {
// Arrange
gin.SetMode(gin.TestMode)
mockAuthService := &MockAuthService{}
handler := handlers.NewAuthHandler(mockAuthService)
router := gin.New()
router.POST("/register", handler.Register)
// Невалидный запрос (пустой email)
invalidReq := map[string]interface{}{
"organization_name": "Test Workshop",
"user_email": "", // Пустой email
"user_password": "password123",
"organization_type": "workshop",
}
reqBody, _ := json.Marshal(invalidReq)
// Act
w := httptest.NewRecorder()
req, _ := http.NewRequest("POST", "/register", bytes.NewBuffer(reqBody))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
// Assert
assert.Equal(t, http.StatusBadRequest, w.Code)
mockAuthService.AssertNotCalled(t, "Register")
}
// TestAuthHandler_Login_Success тестирует успешный вход
func TestAuthHandler_Login_Success(t *testing.T) {
// Arrange
gin.SetMode(gin.TestMode)
mockAuthService := &MockAuthService{}
handler := handlers.NewAuthHandler(mockAuthService)
router := gin.New()
router.POST("/login", handler.Login)
loginReq := &models.LoginRequest{
Email: "admin@test.com",
Password: "password123",
}
expectedResponse := &models.LoginResponse{
Token: "test_token",
User: models.UserResponse{
ID: uuid.New(),
Email: "admin@test.com",
Role: "admin",
},
Organization: models.OrganizationResponse{
ID: uuid.New(),
Name: "Test Workshop",
Type: "workshop",
},
}
mockAuthService.On("Login", mock.Anything, loginReq).Return(expectedResponse, nil)
reqBody, _ := json.Marshal(loginReq)
// Act
w := httptest.NewRecorder()
req, _ := http.NewRequest("POST", "/login", bytes.NewBuffer(reqBody))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
// Assert
assert.Equal(t, http.StatusOK, w.Code)
var response models.LoginResponse
err := json.Unmarshal(w.Body.Bytes(), &response)
assert.NoError(t, err)
assert.Equal(t, expectedResponse.Token, response.Token)
assert.Equal(t, expectedResponse.User.Email, response.User.Email)
mockAuthService.AssertExpectations(t)
}
// TestAuthHandler_Login_ValidationError тестирует ошибку валидации при входе
func TestAuthHandler_Login_ValidationError(t *testing.T) {
// Arrange
gin.SetMode(gin.TestMode)
mockAuthService := &MockAuthService{}
handler := handlers.NewAuthHandler(mockAuthService)
router := gin.New()
router.POST("/login", handler.Login)
// Невалидный запрос (пустой пароль)
invalidReq := map[string]interface{}{
"email": "admin@test.com",
"password": "", // Пустой пароль
}
reqBody, _ := json.Marshal(invalidReq)
// Act
w := httptest.NewRecorder()
req, _ := http.NewRequest("POST", "/login", bytes.NewBuffer(reqBody))
req.Header.Set("Content-Type", "application/json")
router.ServeHTTP(w, req)
// Assert
assert.Equal(t, http.StatusBadRequest, w.Code)
mockAuthService.AssertNotCalled(t, "Login")
}

View File

@@ -0,0 +1,161 @@
package middleware_test
import (
"net/http"
"net/http/httptest"
"testing"
"time"
"github.com/gin-gonic/gin"
"github.com/google/uuid"
"github.com/stretchr/testify/assert"
"erp-mvp/core-service/internal/api/middleware"
"erp-mvp/core-service/internal/auth"
)
// TestNewAuthMiddleware тестирует создание AuthMiddleware
func TestNewAuthMiddleware(t *testing.T) {
// Arrange
jwtService := auth.NewJWTService("test_secret", 24*time.Hour)
// Act
authMiddleware := middleware.NewAuthMiddleware(jwtService)
// Assert
assert.NotNil(t, authMiddleware)
}
// TestAuthMiddleware_ValidToken тестирует middleware с валидным токеном
func TestAuthMiddleware_ValidToken(t *testing.T) {
// Arrange
gin.SetMode(gin.TestMode)
jwtService := auth.NewJWTService("test_secret", 24*time.Hour)
authMiddleware := middleware.NewAuthMiddleware(jwtService)
// Создаем валидный токен
userID := uuid.New()
orgID := uuid.New()
token, err := jwtService.GenerateToken(userID, orgID, "test@example.com", "admin")
assert.NoError(t, err)
router := gin.New()
router.Use(authMiddleware.AuthRequired())
router.GET("/test", func(c *gin.Context) {
c.JSON(http.StatusOK, gin.H{"message": "success"})
})
// Act
w := httptest.NewRecorder()
req, _ := http.NewRequest("GET", "/test", nil)
req.Header.Set("Authorization", "Bearer "+token)
router.ServeHTTP(w, req)
// Assert
assert.Equal(t, http.StatusOK, w.Code)
}
// TestAuthMiddleware_NoToken тестирует middleware без токена
func TestAuthMiddleware_NoToken(t *testing.T) {
// Arrange
gin.SetMode(gin.TestMode)
jwtService := auth.NewJWTService("test_secret", 24*time.Hour)
authMiddleware := middleware.NewAuthMiddleware(jwtService)
router := gin.New()
router.Use(authMiddleware.AuthRequired())
router.GET("/test", func(c *gin.Context) {
c.JSON(http.StatusOK, gin.H{"message": "success"})
})
// Act
w := httptest.NewRecorder()
req, _ := http.NewRequest("GET", "/test", nil)
router.ServeHTTP(w, req)
// Assert
assert.Equal(t, http.StatusUnauthorized, w.Code)
}
// TestAuthMiddleware_InvalidToken тестирует middleware с невалидным токеном
func TestAuthMiddleware_InvalidToken(t *testing.T) {
// Arrange
gin.SetMode(gin.TestMode)
jwtService := auth.NewJWTService("test_secret", 24*time.Hour)
authMiddleware := middleware.NewAuthMiddleware(jwtService)
router := gin.New()
router.Use(authMiddleware.AuthRequired())
router.GET("/test", func(c *gin.Context) {
c.JSON(http.StatusOK, gin.H{"message": "success"})
})
// Act
w := httptest.NewRecorder()
req, _ := http.NewRequest("GET", "/test", nil)
req.Header.Set("Authorization", "Bearer invalid_token")
router.ServeHTTP(w, req)
// Assert
assert.Equal(t, http.StatusUnauthorized, w.Code)
}
// TestAuthMiddleware_InvalidHeader тестирует middleware с невалидным заголовком
func TestAuthMiddleware_InvalidHeader(t *testing.T) {
// Arrange
gin.SetMode(gin.TestMode)
jwtService := auth.NewJWTService("test_secret", 24*time.Hour)
authMiddleware := middleware.NewAuthMiddleware(jwtService)
router := gin.New()
router.Use(authMiddleware.AuthRequired())
router.GET("/test", func(c *gin.Context) {
c.JSON(http.StatusOK, gin.H{"message": "success"})
})
// Act
w := httptest.NewRecorder()
req, _ := http.NewRequest("GET", "/test", nil)
req.Header.Set("Authorization", "InvalidFormat token")
router.ServeHTTP(w, req)
// Assert
assert.Equal(t, http.StatusUnauthorized, w.Code)
}
// TestGetClaims тестирует извлечение claims из контекста
func TestGetClaims(t *testing.T) {
// Arrange
gin.SetMode(gin.TestMode)
userID := uuid.New()
orgID := uuid.New()
email := "test@example.com"
role := "admin"
router := gin.New()
router.GET("/test", func(c *gin.Context) {
// Устанавливаем claims в контекст
c.Set("user_id", userID)
c.Set("organization_id", orgID)
c.Set("email", email)
c.Set("role", role)
// Извлекаем claims
claims := middleware.GetClaims(c)
assert.NotNil(t, claims)
assert.Equal(t, userID, claims.UserID)
assert.Equal(t, orgID, claims.OrganizationID)
assert.Equal(t, email, claims.Email)
assert.Equal(t, role, claims.Role)
c.JSON(http.StatusOK, gin.H{"message": "success"})
})
// Act
w := httptest.NewRecorder()
req, _ := http.NewRequest("GET", "/test", nil)
router.ServeHTTP(w, req)
// Assert
assert.Equal(t, http.StatusOK, w.Code)
}

View File

@@ -299,6 +299,78 @@ func TestItemRepository_Create(t *testing.T) {
assert.NoError(t, mock.ExpectationsWereMet()) assert.NoError(t, mock.ExpectationsWereMet())
} }
// TestItemRepository_GetByID тестирует получение товара по ID
func TestItemRepository_GetByID(t *testing.T) {
// Arrange
db, mock, err := sqlmock.New()
require.NoError(t, err)
defer db.Close()
repo := repository.NewItemRepository(db)
itemID := uuid.New()
expectedItem := &models.Item{
ID: itemID,
Name: "Test Item",
Description: "Test Description",
Category: "electronics",
}
orgID := uuid.New()
// Ожидаем SQL запрос
rows := sqlmock.NewRows([]string{"id", "organization_id", "name", "description", "category", "created_at"}).
AddRow(itemID, orgID, expectedItem.Name, expectedItem.Description, expectedItem.Category, time.Now())
mock.ExpectQuery("SELECT (.+) FROM items").
WithArgs(itemID, orgID).
WillReturnRows(rows)
// Act
item, err := repo.GetByID(context.Background(), itemID, orgID)
// Assert
assert.NoError(t, err)
assert.NotNil(t, item)
assert.Equal(t, expectedItem.ID, item.ID)
assert.Equal(t, expectedItem.Name, item.Name)
assert.Equal(t, expectedItem.Category, item.Category)
assert.NoError(t, mock.ExpectationsWereMet())
}
// TestItemRepository_GetByOrganization тестирует получение товаров по организации
func TestItemRepository_GetByOrganization(t *testing.T) {
// Arrange
db, mock, err := sqlmock.New()
require.NoError(t, err)
defer db.Close()
repo := repository.NewItemRepository(db)
orgID := uuid.New()
itemID1 := uuid.New()
itemID2 := uuid.New()
// Ожидаем SQL запрос
rows := sqlmock.NewRows([]string{"id", "organization_id", "name", "description", "category", "created_at"}).
AddRow(itemID1, orgID, "Item 1", "Description 1", "electronics", time.Now()).
AddRow(itemID2, orgID, "Item 2", "Description 2", "clothing", time.Now())
mock.ExpectQuery("SELECT (.+) FROM items").
WithArgs(orgID).
WillReturnRows(rows)
// Act
items, err := repo.GetByOrganization(context.Background(), orgID)
// Assert
assert.NoError(t, err)
assert.Len(t, items, 2)
assert.Equal(t, "Item 1", items[0].Name)
assert.Equal(t, "Item 2", items[1].Name)
assert.NoError(t, mock.ExpectationsWereMet())
}
// TestOperationsRepository_PlaceItem тестирует размещение товара // TestOperationsRepository_PlaceItem тестирует размещение товара
func TestOperationsRepository_PlaceItem(t *testing.T) { func TestOperationsRepository_PlaceItem(t *testing.T) {
// Arrange // Arrange
@@ -371,3 +443,36 @@ func TestOperationsRepository_Search(t *testing.T) {
assert.Len(t, results, 1) assert.Len(t, results, 1)
assert.NoError(t, mock.ExpectationsWereMet()) assert.NoError(t, mock.ExpectationsWereMet())
} }
// TestLocationRepository_GetByOrganization тестирует получение локаций по организации
func TestLocationRepository_GetByOrganization(t *testing.T) {
// Arrange
db, mock, err := sqlmock.New()
require.NoError(t, err)
defer db.Close()
repo := repository.NewLocationRepository(db)
orgID := uuid.New()
locationID1 := uuid.New()
locationID2 := uuid.New()
// Ожидаем SQL запрос
rows := sqlmock.NewRows([]string{"id", "organization_id", "parent_id", "name", "address", "type", "coordinates", "created_at"}).
AddRow(locationID1, orgID, nil, "Warehouse A", "123 Main St", "warehouse", `{"lat": 55.7558, "lng": 37.6176}`, time.Now()).
AddRow(locationID2, orgID, &locationID1, "Shelf 1", "Warehouse A, Section 1", "shelf", `{"row": 1, "column": 1}`, time.Now())
mock.ExpectQuery("SELECT (.+) FROM storage_locations").
WithArgs(orgID).
WillReturnRows(rows)
// Act
locations, err := repo.GetByOrganization(context.Background(), orgID)
// Assert
assert.NoError(t, err)
assert.Len(t, locations, 2)
assert.Equal(t, "Warehouse A", locations[0].Name)
assert.Equal(t, "Shelf 1", locations[1].Name)
assert.NoError(t, mock.ExpectationsWereMet())
}